-
-
Notifications
You must be signed in to change notification settings - Fork 250
chore(pipeline): use infra.getBuildAgentLabel in agentSelector
#1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lemeurherve
merged 5 commits into
jenkinsci:master
from
lemeurherve:use-a-switch-in-agentselector
Jan 29, 2026
Merged
chore(pipeline): use infra.getBuildAgentLabel in agentSelector
#1137
lemeurherve
merged 5 commits into
jenkinsci:master
from
lemeurherve:use-a-switch-in-agentselector
Jan 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc1467f to
19426ec
Compare
agentLabelSelectorinfra.getBuildAgentLabel
ba93953 to
f7de2ce
Compare
df90d51 to
b8ed89c
Compare
infra.getBuildAgentLabelinfra.getBuildAgentLabel in agentSelector
4fa1a13 to
bf2ce89
Compare
6 tasks
d13adbc to
91dede7
Compare
91dede7 to
dd29d08
Compare
timja
reviewed
Jan 29, 2026
Member
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think doing it with the last number is a bit magic and could be clearer with more specific regexes
Co-authored-by: Tim Jacomb <[email protected]>
timja
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the multiple
ifcases and thespotSelectorfunction by a call to theinfra.getAgentLabelglobal pipeline library function, as a centralised point to retrieve the appropriate agent template labels depending on the requested platform (no JDK implicated in those docker image builds), and on the controller where the job is running (ex: "fallback to fromdocker-highmemtolinux" or "nospot/nonspotlabels" on trusted.ci.jenkins.io).Recommanded view: https://github.com/jenkinsci/docker-agents/pull/1137/changes?diff=split
Extracted from:
Refs:
Testing done
CI +
infra.getBuildAgentLabelunit testsSubmitter checklist